Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task024 #7

Merged
merged 4 commits into from
Aug 27, 2024
Merged

task024 #7

merged 4 commits into from
Aug 27, 2024

Conversation

ahuoguo
Copy link
Contributor

@ahuoguo ahuoguo commented Aug 11, 2024

I require n > 1 since the python implementation did not take care of arguments outside of it. (It will actually return None)

Copy link
Contributor

@parno parno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! Would you mind running verusfmt on the file, if you haven't already?

}

/// Specification for what it means for d to divide a
pub open spec fn divides(v: nat, d: nat) -> bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reverse the ordering of the arguments in divides, so that it matches the English connotation, i.e., so divides(d, v) matches "d divides v"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuoguo
Copy link
Contributor Author

ahuoguo commented Aug 20, 2024

Also a brief scan on verusfmt --check --verus-only *.rs, seems like 004 and 003c did not run verusfmt, might add that as a CI check?

@parno
Copy link
Contributor

parno commented Aug 20, 2024

Also a brief scan on verusfmt --check --verus-only *.rs, seems like 004 and 003c did not run verusfmt, might add that as a CI check?

Yes, that's somewhere on our to-do list.

@jaybosamiya
Copy link
Member

jaybosamiya commented Aug 22, 2024

PR #8 adds a CI check for verusfmt

@parno
Copy link
Contributor

parno commented Aug 27, 2024

Thanks @jaybosamiya! @ahuoguo once you run verusfmt on your code, we can get it merged in.

@ahuoguo
Copy link
Contributor Author

ahuoguo commented Aug 27, 2024

i’ve already ran it

@parno
Copy link
Contributor

parno commented Aug 27, 2024

Great, thanks!

@parno parno merged commit 34623ff into secure-foundations:main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants